from fontbakery.message import Message
from fontbakery.callable import check
from fontbakery.checkrunner import FAIL, PASS, WARN
# used to inform get_module_profile whether and how to create a profile
from fontbakery.fonts_profile import profile_factory # NOQA pylint: disable=unused-import
import fontTools.ttLib
[docs]@check(
id = 'com.google.fonts/check/glyf_unused_data',
conditions = ['is_ttf']
)
def com_google_fonts_check_glyf_unused_data(ttFont):
"""Is there any unused data at the end of the glyf table?"""
try:
expected_glyphs = len(ttFont.getGlyphOrder())
actual_glyphs = len(ttFont['glyf'].glyphs)
diff = actual_glyphs - expected_glyphs
if diff < 0:
yield FAIL,\
Message("unreachable-data",
f"Glyf table has unreachable data at the end of the table."
f" Expected glyf table length {expected_glyphs} (from loca"
f" table), got length {actual_glyphs}"
f" (difference: {diff})")
elif not diff: # negative diff -> exception below
yield PASS, "There is no unused data at the end of the glyf table."
else:
raise Exception("Bug: fontTools did not raise an expected exception.")
except fontTools.ttLib.TTLibError as error:
if "not enough 'glyf' table data" in format(error):
yield FAIL,\
Message("missing-data",
f"Loca table references data beyond"
f" the end of the glyf table."
f" Expected glyf table length {expected_glyphs}"
f" (from loca table).")
else:
raise Exception("Bug: Unexpected fontTools exception.")
# This check was originally ported from
# Mekkablue Preflight Checks available at:
# https://github.com/mekkablue/Glyphs-Scripts/blob/master/Test/Preflight%20Font.py
[docs]@check(
id = 'com.google.fonts/check/points_out_of_bounds',
conditions = ['is_ttf'],
misc_metadata = {
'request': 'https://github.com/googlefonts/fontbakery/issues/735'
}
)
def com_google_fonts_check_points_out_of_bounds(ttFont):
"""Check for points out of bounds."""
from fontbakery.utils import pretty_print_list
passed = True
out_of_bounds = []
for glyphName in ttFont['glyf'].keys():
glyph = ttFont['glyf'][glyphName]
coords = glyph.getCoordinates(ttFont['glyf'])[0]
for x, y in coords:
if round(x) < glyph.xMin or round(x) > glyph.xMax or \
round(y) < glyph.yMin or round(y) > glyph.yMax or \
abs(x) > 32766 or abs(y) > 32766:
passed = False
out_of_bounds.append((glyphName, x, y))
if not passed:
formatted_list = "\t* " + pretty_print_list(out_of_bounds,
shorten=10,
sep="\n\t* ")
yield WARN,\
Message("points-out-of-bounds",
f"The following glyphs have coordinates"
f" which are out of bounds:\n"
f"{formatted_list}\n"
f"\n"
f"This happens a lot when points are not extremes,"
f" which is usually bad. However, fixing this alert"
f" by adding points on extremes may do more harm"
f" than good, especially with italics,"
f" calligraphic-script, handwriting, rounded and"
f" other fonts. So it is common to ignore this message.")
else:
yield PASS, "All glyph paths have coordinates within bounds!"
[docs]@check(
id = 'com.google.fonts/check/glyf_nested_components',
rationale = """
There have been bugs rendering variable fonts with nested components. Additionally, some static fonts with nested components have been reported to have rendering and printing issues.
For more info, see:
* https://github.com/googlefonts/fontbakery/issues/2961
* https://github.com/arrowtype/recursive/issues/412
""",
conditions = ['is_ttf'],
misc_metadata = {
'request': 'https://github.com/googlefonts/fontbakery/issues/2961'
}
)
def com_google_fonts_check_glyf_nested_components(ttFont):
"""Check glyphs do not have components which are themselves components."""
from fontbakery.utils import pretty_print_list
failed = []
for glyph_name in ttFont['glyf'].keys():
glyph = ttFont['glyf'][glyph_name]
if not glyph.isComposite():
continue
for comp in glyph.components:
if ttFont['glyf'][comp.glyphName].isComposite():
failed.append(glyph_name)
if failed:
formatted_list = "\t* " + pretty_print_list(failed,
shorten=10,
sep="\n\t* ")
yield FAIL, \
Message('found-nested-components',
f"The following glyphs have components which"
f" themselves are component glyphs:\n"
f"{formatted_list}")
else:
yield PASS, ("Glyphs do not contain nested components.")