Source code for fontbakery.profiles.ufo_sources

import re

from fontbakery.callable import check, condition
from fontbakery.status import ERROR, FAIL, PASS, SKIP, WARN
from fontbakery.section import Section
from fontbakery.message import Message
from fontbakery.fonts_profile import profile_factory
from fontbakery.utils import exit_with_install_instructions


profile = profile_factory(default_section=Section("UFO Sources"))

UFO_PROFILE_CHECKS = [
    "com.daltonmaag/check/ufolint",
    "com.daltonmaag/check/ufo_required_fields",
    "com.daltonmaag/check/ufo_recommended_fields",
    "com.daltonmaag/check/ufo_unnecessary_fields",
    "com.google.fonts/check/designspace_has_sources",
    "com.google.fonts/check/designspace_has_default_master",
    "com.google.fonts/check/designspace_has_consistent_glyphset",
    "com.google.fonts/check/designspace_has_consistent_codepoints",
    "com.thetypefounders/check/features_default_languagesystem",
]


[docs]@condition def ufo_font(ufo): try: from fontTools.ufoLib.errors import UFOLibError import defcon except ImportError: exit_with_install_instructions() try: return defcon.Font(ufo) except UFOLibError: return None
[docs]@condition def designSpace(designspace): """ Given a filepath for a designspace file, parse it and return a DesignSpaceDocument, which is 'an object to read, write and edit interpolation systems for typefaces'. """ try: from fontTools.designspaceLib import DesignSpaceDocument import defcon except ImportError: exit_with_install_instructions() if designspace: DS = DesignSpaceDocument.fromfile(designspace) DS.loadSourceFonts(defcon.Font) return DS
[docs]@condition def designspace_sources(designSpace): """ Given a DesignSpaceDocument object, return a set of UFO font sources. """ try: import defcon except ImportError: exit_with_install_instructions() if designSpace: return designSpace.loadSourceFonts(defcon.Font)
[docs]@check( id="com.daltonmaag/check/ufolint", proposal="https://github.com/fonttools/fontbakery/pull/1736", ) def com_daltonmaag_check_ufolint(ufo): """Run ufolint on UFO source directory.""" # IMPORTANT: This check cannot use the 'ufo_font' condition because it makes it # skip malformed UFOs (e.g. if metainfo.plist file is missing). import subprocess ufolint_cmd = ["ufolint", ufo] try: subprocess.check_output(ufolint_cmd, stderr=subprocess.STDOUT) except subprocess.CalledProcessError as e: yield FAIL, Message( "ufolint-fail", ("ufolint failed the UFO source. Output follows :" "\n\n{}\n").format( e.output.decode() ), ) except OSError: yield ERROR, Message("ufolint-unavailable", "ufolint is not available!") else: yield PASS, "ufolint passed the UFO source."
[docs]@check( id="com.daltonmaag/check/ufo_required_fields", conditions=["ufo_font"], rationale=""" ufo2ft requires these info fields to compile a font binary: unitsPerEm, ascender, descender, xHeight, capHeight and familyName. """, proposal="https://github.com/fonttools/fontbakery/pull/1736", ) def com_daltonmaag_check_required_fields(ufo_font): """Check that required fields are present in the UFO fontinfo.""" required_fields = [] for field in [ "unitsPerEm", "ascender", "descender", "xHeight", "capHeight", "familyName", ]: if ufo_font.info.__dict__.get("_" + field) is None: required_fields.append(field) if required_fields: yield FAIL, Message( "missing-required-fields", f"Required field(s) missing: {required_fields}" ) else: yield PASS, "Required fields present."
[docs]@check( id="com.daltonmaag/check/ufo_unnecessary_fields", conditions=["ufo_font"], rationale=""" ufo2ft will generate these. openTypeOS2UnicodeRanges and openTypeOS2CodePageRanges are exempted because it is useful to toggle a range when not _all_ the glyphs in that region are present. year is deprecated since UFO v2. """, proposal="https://github.com/fonttools/fontbakery/pull/1736", ) def com_daltonmaag_check_unnecessary_fields(ufo_font): """Check that no unnecessary fields are present in the UFO fontinfo.""" unnecessary_fields = [] for field in [ "openTypeNameUniqueID", "openTypeNameVersion", "postscriptUniqueID", "year", ]: if ufo_font.info.__dict__.get("_" + field) is not None: unnecessary_fields.append(field) if unnecessary_fields: yield WARN, Message( "unnecessary-fields", f"Unnecessary field(s) present: {unnecessary_fields}" ) else: yield PASS, "Unnecessary fields omitted."
# The following fields are always generated empty by defcon: # guidelines, postscriptBlueValues, postscriptOtherBlues, # postscriptFamilyBlues, postscriptFamilyOtherBlues, # postscriptStemSnapH, postscriptStemSnapV -- not sure if checking for that # is useful.
[docs]@check( id="com.google.fonts/check/designspace_has_sources", rationale=""" This check parses a designspace file and tries to load the source files specified. This is meant to ensure that the file is not malformed, can be properly parsed and does include valid source file references. """, proposal="https://github.com/fonttools/fontbakery/pull/3168", ) def com_google_fonts_check_designspace_has_sources(designspace_sources): """See if we can actually load the source files.""" if not designspace_sources: yield FAIL, Message("no-sources", "Unable to load source files.") else: yield PASS, "OK"
[docs]@check( id="com.google.fonts/check/designspace_has_default_master", rationale=""" We expect that designspace files declare on of the masters as default. """, proposal="https://github.com/fonttools/fontbakery/pull/3168", ) def com_google_fonts_check_designspace_has_default_master(designSpace): """Ensure a default master is defined.""" if not designSpace.findDefault(): yield FAIL, Message("not-found", "Unable to find a default master.") else: yield PASS, "We located a default master."
[docs]@check( id="com.google.fonts/check/designspace_has_consistent_glyphset", rationale=""" This check ensures that non-default masters don't have glyphs not present in the default one. """, conditions=["designspace_sources"], proposal="https://github.com/fonttools/fontbakery/pull/3168", ) def com_google_fonts_check_designspace_has_consistent_glyphset(designSpace, config): """Check consistency of glyphset in a designspace file.""" from fontbakery.utils import bullet_list default_glyphset = set(designSpace.findDefault().font.keys()) failures = [] for source in designSpace.sources: master_glyphset = set(source.font.keys()) outliers = master_glyphset - default_glyphset if outliers: outliers = ", ".join(list(outliers)) failures.append( f"Source {source.filename} has glyphs not present" f" in the default master: {outliers}" ) if failures: yield FAIL, Message( "inconsistent-glyphset", f"Glyphsets were not consistent:\n\n" f"{bullet_list(config, failures)}", ) else: yield PASS, "Glyphsets were consistent."
[docs]@check( id="com.google.fonts/check/designspace_has_consistent_codepoints", rationale=""" This check ensures that Unicode assignments are consistent across all sources specified in a designspace file. """, conditions=["designspace_sources"], proposal="https://github.com/fonttools/fontbakery/pull/3168", ) def com_google_fonts_check_designspace_has_consistent_codepoints(designSpace, config): """Check codepoints consistency in a designspace file.""" from fontbakery.utils import bullet_list default_source = designSpace.findDefault() default_unicodes = {g.name: g.unicode for g in default_source.font} failures = [] for source in designSpace.sources: for g in source.font: if g.name not in default_unicodes: # Previous test will cover this continue if g.unicode != default_unicodes[g.name]: failures.append( f"Source {source.filename} has" f" {g.name}={g.unicode};" f" default master has" f" {g.name}={default_unicodes[g.name]}" ) if failures: yield FAIL, Message( "inconsistent-codepoints", f"Unicode assignments were not consistent:\n\n" f"{bullet_list(config, failures)}", ) else: yield PASS, "Unicode assignments were consistent."
[docs]@check( id="com.thetypefounders/check/features_default_languagesystem", conditions=["ufo_font"], rationale=""" The feature file specification strongly recommends to use a `languagesystem DFLT dflt` statement in your feature file. This statement is automatically inserted when no `languagesystem` statements are present in the feature file, *unless* there is another `languagesystem` statement already present. If this is the case, this behaviour could lead to unintended side effects. This check only WARNs when this happen as there are cases where not having a `languagesystem DFLT dflt` statement in your feature file is technically correct. http://adobe-type-tools.github.io/afdko/OpenTypeFeatureFileSpecification.html#4b-language-system """, proposal="https://github.com/googlefonts/fontbakery/issues/4011", ) def com_thetypefounders_check_features_default_languagesystem(ufo_font): """Check that languagesystem DFLT dflt is present in the features.fea file.""" if ufo_font.features.text is None: yield SKIP, "No features.fea file in font." elif not ufo_font.features.text.strip(): yield PASS, "Default languagesystem inserted by compiler." else: tags = re.findall( # pylint: disable-next=line-too-long r"languagesystem\s+([A-Za-z0-9\._!$%&*+:?^'|~]{1,4})\s+([A-Za-z0-9\._!$%&*+:?^'|~]{1,4})", # noqa E501 ufo_font.features.text, ) if len(tags) > 0 and ("DFLT", "dflt") != tags[0]: tags_str = ", ".join([" ".join(t) for t in tags]) yield WARN, Message( "default-languagesystem", f"Default languagesystem not found in: {tags_str}.", ) else: yield PASS, "Default languagesystem present or automatically inserted."
profile.auto_register(globals()) profile.test_expected_checks(UFO_PROFILE_CHECKS, exclusive=True)